[Lldb-commits] [PATCH] D84716: [lldb/ArchSpec] Always match simulator environment in IsEqualTo

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 27 17:11:11 PDT 2020


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Yes, this makes perfect sense. Thanks!



================
Comment at: lldb/unittests/Utility/ArchSpecTest.cpp:329
     ASSERT_FALSE(A.IsExactMatch(B));
     // FIXME: See above, though the extra environment complicates things.
     ASSERT_FALSE(A.IsCompatibleMatch(B));
----------------
What's to fix here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84716/new/

https://reviews.llvm.org/D84716





More information about the lldb-commits mailing list