[Lldb-commits] [PATCH] D84401: [lldb] Add SectionList::ContainsFileAddressRange

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: lldb/include/lldb/Core/Section.h:75
+  /// sections in this list.
+  bool ContainsFileAddressRange(lldb::addr_t addr, lldb::addr_t size) const;
+
----------------
JDevlieghere wrote:
> `addr_t` looks a bit weird for the size, but then `offset_t` also wouldn't make sense. `uint64_t` maybe? I'll leave it up to you. 
Can we use Range<AddrType, SizeType> from RangeMap.h here?
```
using Range = Range<lldb::addr_t, uint64_t>;
bool ContainsFileAddressRange(Range range) const;
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84401/new/

https://reviews.llvm.org/D84401