[Lldb-commits] [PATCH] D84401: [lldb] Add SectionList::ContainsFileAddressRange

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/include/lldb/Core/Section.h:75
+  /// sections in this list.
+  bool ContainsFileAddressRange(lldb::addr_t addr, lldb::addr_t size) const;
+
----------------
`addr_t` looks a bit weird for the size, but then `offset_t` also wouldn't make sense. `uint64_t` maybe? I'll leave it up to you. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84401/new/

https://reviews.llvm.org/D84401