[Lldb-commits] [PATCH] D84285: Unify the return value of GetByteSize to an llvm::Optional<uint64_t> (NFC-ish)

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lldb/source/Expression/Materializer.cpp:283
                   (uint64_t)mem,
-                  (unsigned long long)m_persistent_variable_sp->GetByteSize());
+                  (unsigned long long)m_persistent_variable_sp->GetByteSize()
+                      .getValueOr(0));
----------------
Why does this need a cast?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84285/new/

https://reviews.llvm.org/D84285