[Lldb-commits] [PATCH] D84285: Unify the return value of GetByteSize to an llvm::Optional<uint64_t> (NFC-ish)

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 21 17:35:26 PDT 2020


aprantl marked an inline comment as done.
aprantl added inline comments.


================
Comment at: lldb/source/Target/StackFrame.cpp:1445
+    int64_t index = offset / pointee->GetByteSize().getValueOr(1);
+    offset = offset % pointee->GetByteSize().getValueOr(1);
     const bool can_create = true;
----------------
Yeah, I know.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84285/new/

https://reviews.llvm.org/D84285





More information about the lldb-commits mailing list