[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In D82064#2152807 <https://reviews.llvm.org/D82064#2152807>, @omjavaid wrote:

> Updated after incorporating review comments.
>
> @rovka I gave your idea a thought about moving included scripts to lldb/utils. IMO these scripts have no relationship with LLDB and no such precedent exist where we uploaded such tools or utilities in LLDB source tree. Lets have other opinions and finalize.


The relationship to lldb is that it can be used to setup lldb for cross-testing. And I personally don't see a difference between a standalone bash script stashed somewhere inside the repo, and having that script embedded inside a `.txt` file. The bar for stashing a script into the repo is fairly low, and this seems useful enough to cross it, particularly if it can handle architectures other than arm (I do like the idea of making the description generic, and then mention arm/sve specific in a separate section or file).



================
Comment at: lldb/docs/lldb-qemu-aarch64-sve-howto.txt:39-40
+RFS_IMG_NAME=$1
+shift
+RFS_IMG_SIZE_GB=$1
+shift
----------------
Why not just `RFS_IMG_SIZE_GB=$2`, etc., without all the shifts?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82064/new/

https://reviews.llvm.org/D82064