[Lldb-commits] [lldb] 29aab9b - [lldb] Use the basename of the Python test for the log name instead of the class name

[Raphael Isemann via lldb-commits]

Author: Raphael Isemann
Date: 2020-07-15T13:54:43+02:00
New Revision: 29aab9b5c748b28b231e2ca0f9b95453638ade1a

URL: https://github.com/llvm/llvm-project/commit/29aab9b5c748b28b231e2ca0f9b95453638ade1a
DIFF: https://github.com/llvm/llvm-project/commit/29aab9b5c748b28b231e2ca0f9b95453638ade1a.diff

LOG: [lldb] Use the basename of the Python test for the log name instead of the class name

Summary:

>From what I know we already have the restriction that every test in the test
suite needs to have a unique file name as that's used for generating the unique
build directory for a test. It seems there is also a restriction that every test
case class in the test suite needs to have a unique name as that's used to
generate the unique log file name for the test run.

This changes the log file format to use the basename of the test file instead so
that we only have to keep worrying about the 'unique file name' restriction from
now on.

This came up because I started naming the test classes "TestCase" (as repeating
the file name in the test class seems like redudant information that just makes
renaming tests a pain).

Reviewers: labath, JDevlieghere

Reviewed By: labath

Subscribers: mgorny, abidh

Differential Revision: https://reviews.llvm.org/D83767

Added: 
    

Modified: 
    lldb/test/API/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/CMakeLists.txt b/lldb/test/API/CMakeLists.txt
index 34f3522c8dfe..23b211e14cfa 100644
--- a/lldb/test/API/CMakeLists.txt
+++ b/lldb/test/API/CMakeLists.txt
@@ -38,7 +38,7 @@ set(LLDB_TEST_USER_ARGS
 set(LLDB_TEST_COMMON_ARGS
   -s
   ${CMAKE_BINARY_DIR}/lldb-test-traces
-  -S nm
+  -S fm
   -u CXXFLAGS
   -u CFLAGS
   )