[Lldb-commits] [PATCH] D82759: [lldb/Test] Introduce "assertSuccess"
Raphael Isemann via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Jun 30 04:18:57 PDT 2020
teemperor accepted this revision.
teemperor added a comment.
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2537
+ def assertSuccess(self, obj, msg=None):
+ if not obj.Success():
+ error = obj.GetCString()
> I'm not actually sure this works for custom types, but should we add an `assert isinstance(obj, lldb.SBError)` to avoid misuse?
I actually also wondered if `obj` can be anything else in LLDB's SB API. I guess it's Pythonic to allow anything that fits that signature but some one-line documentaiton that this intended is for SBError would be nice.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits