[Lldb-commits] [PATCH] D82759: [lldb/Test] Introduce "assertSuccess"
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Jun 29 09:43:26 PDT 2020
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Looks like a great improvement!
At some point we should document our custom methods in https://lldb.llvm.org/resources/test.html to make them more discoverable, but that's orthogonal to this patch.
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2537
+ def assertSuccess(self, obj, msg=None):
+ if not obj.Success():
+ error = obj.GetCString()
I'm not actually sure this works for custom types, but should we add an `assert isinstance(obj, lldb.SBError)` to avoid misuse?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits