[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

Mon Jun 29 05:54:20 PDT 2020

jankratochvil added a comment.

In D74136#2119549 <https://reviews.llvm.org/D74136#2119549>, @labath wrote:

> At this point I'm getting very lost in this patch,

Me too, as you stated:

In D74136#2020245 <https://reviews.llvm.org/D74136#2020245>, @labath wrote:

> In D74136#1983467 <https://reviews.llvm.org/D74136#1983467>, @kwk wrote:
>
> > I will obviously rename `SearchFilterByModuleListAndCU` but that can come in a child revision.
>

...

> I think it'd be best to do the rename as a part of this patch.

So I have to always undo the renaming before understanding what the patch does now. It would be nice if you could take back the merge of renaming.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74136/new/

https://reviews.llvm.org/D74136