[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and core file support

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 29 04:17:16 PDT 2020

labath added a comment.

I'm worried about the confusing relationship between `RegisterInfos_arm64_sve.h` and `RegisterInfos_arm64.h` and the overlap in the register numbers it enforces. when we discussed this last time, my understanding was that the sve registers could be inserted _before_ the debug registers (similar to what happened with D24255 <https://reviews.llvm.org/D24255>). Now I see that may not be possible because some of these registers are used in the darwin arm64 register context. However, that makes the whole idea much less appealing.

Would it be possible to organize these headers like this:

- create a new header which holds common register definitions: this would be register numbers for the gpr and fpr registers (and their respective `_contains` arrays).
- have `RegisterInfos_arm64_sve.h` include this header and provide additional register definitions, and define its RegisterInfo array to match
- have `RegisterInfos_arm64.h` to the same

What I am hoping to achieve this way is to remove the `DECLARE_REGISTER_INFOS_ARM64_SVE_STRUCT` condition macro (dragons (ODR violations) lie there), and the duplicate enum values associated with it.



More information about the lldb-commits mailing list