[Lldb-commits] [PATCH] D82187: [AArch64][SVE] ACLE: Add bfloat16 to struct load/stores.

[Sander de Smalen via Phabricator via lldb-commits]

sdesmalen marked 2 inline comments as done.
sdesmalen added inline comments.


================
Comment at: clang/include/clang/Basic/AArch64SVEACLETypes.def:69
 
-SVE_VECTOR_TYPE("__SVBFloat16_t", "__SVBFloat16_t", SveBFloat16, SveBFloat16Ty, 8, 16, false, false, true)
+SVE_VECTOR_TYPE("__SVBFloat16_t", "__SVBFloat16_t", SveBFloat16, SveBFloat16Ty, 8, 16, true, false, true)
 
----------------
fpetrogalli wrote:
> Why did you have to set `IsFP = true`? Seems like an unrelated change?
It's more for consistency with the other definitions (svfloat16/svfloat32/..) but is otherwise a non-functional change.


================
Comment at: clang/utils/TableGen/SveEmitter.cpp:541
     Float = false;
+    BFloat = false;
     ElementBitwidth /= 4;
----------------
fpetrogalli wrote:
> Are these needed? I don't understand the rule for when to be specific on the values of these variables.
For this patch, it's needed for `'l'` because otherwise it will incorrectly assume the type is bfloat if the type specifier is `b`.
It similarly applies to all the other modifiers that are defined as being of type `integer`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82187/new/

https://reviews.llvm.org/D82187