[Lldb-commits] [PATCH] D82187: [AArch64][SVE] ACLE: Add bfloat16 to struct load/stores.

[Francesco Petrogalli via Phabricator via lldb-commits]

fpetrogalli added inline comments.


================
Comment at: clang/include/clang/Basic/AArch64SVEACLETypes.def:69
 
-SVE_VECTOR_TYPE("__SVBFloat16_t", "__SVBFloat16_t", SveBFloat16, SveBFloat16Ty, 8, 16, false, false, true)
+SVE_VECTOR_TYPE("__SVBFloat16_t", "__SVBFloat16_t", SveBFloat16, SveBFloat16Ty, 8, 16, true, false, true)
 
----------------
Why did you have to set `IsFP = true`? Seems like an unrelated change?


================
Comment at: clang/utils/TableGen/SveEmitter.cpp:541
     Float = false;
+    BFloat = false;
     ElementBitwidth /= 4;
----------------
Are these needed? I don't understand the rule for when to be specific on the values of these variables.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82187/new/

https://reviews.llvm.org/D82187