[Lldb-commits] [PATCH] D81980: Repair support for launching iphone/tv/watch simulator binaries through platform

[Adrian Prantl via Phabricator via lldb-commits]

aprantl updated this revision to Diff 271877.
aprantl marked an inline comment as done.
aprantl added a comment.

Simplify version detection.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81980/new/

https://reviews.llvm.org/D81980

Files:
  lldb/packages/Python/lldbsuite/test/make/Makefile.rules


Index: lldb/packages/Python/lldbsuite/test/make/Makefile.rules
===================================================================
--- lldb/packages/Python/lldbsuite/test/make/Makefile.rules
+++ lldb/packages/Python/lldbsuite/test/make/Makefile.rules
@@ -140,7 +140,10 @@
 			SDKROOT := $(shell xcrun --sdk $(SDK_NAME) --show-sdk-path)
 		endif
 		ifeq "$(TRIPLE_VERSION)" ""
-			TRIPLE_VERSION := $(shell echo $(notdir $(SDKROOT)) | grep -E -o -e '[0-9]+\.[0-9]')
+			ifeq "$(SDK_NAME)" ""
+                               $(error "SDK_NAME is empty")
+			endif
+			TRIPLE_VERSION := $(shell xcrun --sdk $(SDK_NAME) --show-sdk-version)
 		endif
 		ifeq "$(TRIPLE_ENV)" "simulator"
 			ARCH_CFLAGS := -m$(TRIPLE_OS)-simulator-version-min=$(TRIPLE_VERSION)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81980.271877.patch
Type: text/x-patch
Size: 755 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200618/f670c5eb/attachment-0001.bin>