[Lldb-commits] [PATCH] D81980: Repair support for launching iphone/tv/watch simulator binaries through platform

[Vedant Kumar via Phabricator via lldb-commits]

vsk added a comment.

Generally this looks really nice!



================
Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:135
+			ifeq "$(TRIPLE_ENV)" ""
+				CODESIGN := codesign
+			endif
----------------
If I've read this correctly, this means we'll only sign when `TRIPLE_OS == "macosx" && TRIPLE_ENV == ""`. Is that what we want, or should we be signing everything?


================
Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:143
+		ifeq "$(TRIPLE_VERSION)" ""
+			TRIPLE_VERSION := $(shell echo $(notdir $(SDKROOT)) | grep -E -o -e '[0-9]+\.[0-9]')
+		endif
----------------
Can we just write `xcrun --sdk $(SDK_NAME) --show-sdk-version`?

If not, is the "-e" option to grep redundant, since there's only one pattern to match?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81980/new/

https://reviews.llvm.org/D81980