[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

[Shu Anzai via Phabricator via lldb-commits]

gedatsu217 added inline comments.


================
Comment at: lldb/source/Host/common/Editline.cpp:1244
+    llvm::StringRef indent_chars =
+        "abcdefghijklmnopqrstuvwxzyABCDEFGHIJKLMNOPQRSTUVWXZY1234567890 ";
+    for (char c : indent_chars) {
----------------
teemperor wrote:
> `.-/()[]{};\"'\\!@#$%^&*_` are missing here. Maybe we should just iterate over all ASCII characters and add all printables except newline or something like that to the alphabet.
If I add -, \, and ^, an error occurs because these characters  are probably used in other forms like -a (ll. 1283), \n (ll.1253), and  ^p (ll.1257). Do you know good ways to avoid it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81001/new/

https://reviews.llvm.org/D81001