[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

Fri Jun 12 02:08:07 PDT 2020

labath added inline comments.

================
Comment at: lldb/test/API/tools/lldb-vscode/disconnect/TestVSCode_disconnect.py:68
+
+        self.disconnect_and_check_no_output()
----------------
labath wrote:
> I'm confused as to why we're not expecting any output here. I was under the impression that we want to let the inferior continue in the "attach" case.
When I think about this more, I get even more confused. In the attach case, is the inferior stdout even flowing through the vscode connection? I would expect not..

If that's true, then this test and its description is pretty misleading -- there will not be anything in the stdout stream, but not because we disconnected early -- the stdout will _never_ be there.

What exactly are you trying to test here? Maybe it would be more worthwhile to read the stdout from the popen object to ensure that the inferior does continue to print the number correctly?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81200/new/

https://reviews.llvm.org/D81200