[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Jun 11 14:53:23 PDT 2020
JDevlieghere added a comment.
In D80112#2088504 <https://reviews.llvm.org/D80112#2088504>, @fallkrum wrote:
> It says "This revision is now accepted and ready to land." If I understand correctly I should be able to merge it somehow to the repository. Do not see how to do it though... Could you help to figure it out?
Do you have commit access <https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access>? If not you can ask someone to commit if for you <https://llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator>, Jim or I would be happy to do so.
> Also very unclear why Harbormaster always fails with errors like:
>> [2020-06-11T18:15:11.019Z] Error while processing /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang/llvm-project/lldb/include/lldb/Target/Process.h.
>> [2020-06-11T18:15:11.988Z] 480 warnings and 1 error generated.
>> [2020-06-11T18:15:11.988Z] Error while processing /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang/llvm-project/lldb/source/Target/Process.cpp.
>> [2020-06-11T18:15:12.555Z] 442 warnings and 1 error generated.
>> [2020-06-11T18:15:12.555Z] Error while processing /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang/llvm-project/lldb/unittests/Process/ProcessEventDataTest.cpp.
>> [2020-06-11T18:15:13.122Z] 442 warnings and 1 error generated.
>> [2020-06-11T18:15:13.122Z] Error while processing /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang/llvm-project/lldb/unittests/Thread/ThreadTest.cpp.
I wouldn't worry about it. Pre-commit testing is still in beta and I think you need to use the arc tool for it to work. I'm also not sure if LLDB has been completely integrated yet.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits