[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

Konrad Wilhelm Kleine via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 10 04:20:29 PDT 2020

kwk added a comment.

@labath I've applied all the ideas we ping-ponged yesterday and I decided to go with alternating the `target.inline-breakpoint-strategy` from `always` (the default) to `headers`. This way you can exactly see in the test file how things are behaving. So before going into the actual code review I'd like to ask you and @jingham to take a look at the test file. Is it the behavior described there the desired outcome? Then we can discuss the implementation.

Comment at: lldb/source/Breakpoint/BreakpointResolverName.cpp:320
+        else
+          remove_it = false;
+      }
This is done on purpose to reverse the decision to remove a context for not passing a CU above.

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list