[Lldb-commits] [PATCH] D81501: [lldb/CMake] Make it possible to build against Python 2 with CMake > 3.12

Tue Jun 9 14:21:33 PDT 2020

JDevlieghere created this revision.
JDevlieghere added reviewers: compnerd, jingham, labath.
JDevlieghere added a project: LLDB.
Herald added a subscriber: mgorny.
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

Would be nice to remove this entirely in favour of CMake's builtin support for Python Interpeter and Libraries.

JDevlieghere added a comment.

In D81501#2083359 <https://reviews.llvm.org/D81501#2083359>, @compnerd wrote:

> Would be nice to remove this entirely in favour of CMake's builtin support for Python Interpeter and Libraries.

It'll continue to exist to find Python and SWIG atomically, but at least once we bump the minimum requirement for CMake to 3.12 this file will be a lot simpler.

In addition to having the default fallback from Python 3 to Python 2, it should also be possible to build against Python 2 explicitly. This patch makes that possible by setting `LLDB_PYTHON_VERSION`.

Repository:
  rLLDB LLDB

https://reviews.llvm.org/D81501

Files:
  lldb/cmake/modules/FindPythonInterpAndLibs.cmake

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81501.269661.patch
Type: text/x-patch
Size: 4739 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200609/b698dd4b/attachment.bin>