[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.
Ilya Bukonkin via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Jun 8 16:06:41 PDT 2020
fallkrum added a comment.
In D80112#2081008 <https://reviews.llvm.org/D80112#2081008>, @jingham wrote:
> Humm... So you'll have to test the continue behavior instead, which after all was your original issue. That shouldn't be too hard, however. Just make a breakpoint action that calls "thread suspend" on its thread and returns false for should_stop the first time it is called, and just returns true every time thereafter. Then the program should stop at the second hit of the breakpoint rather than continuing to the exit.
Jim, can you please read summary especially expected result and actual result part once again and tell if everything is clear? Really I can’t get a clue why you asking me to write a test with a program stopping at the second hit when the problem itself was in that it stopped at the second hit when in reality should not because I returned false. If I do the test you suggest (I mean returning true in action the second time and after) debugger will pass it even without applying this patch.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits