[Lldb-commits] [PATCH] D81010: [lldb/DWARF] Fix PC value for artificial tail call frames for the "GNU" case
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jun 3 02:10:19 PDT 2020
labath marked an inline comment as done.
labath added inline comments.
Comment at: lldb/include/lldb/Symbol/Function.h:332
- /// The address of the call instruction. Usually an invalid address, unless
- /// this is a tail call.
- lldb::addr_t call_inst_pc;
+ bool caller_address_type : 1, is_tail_call : 1;
> It seems like there's going to be around sizeof(void *) bytes worth of padding here. Maybe it'd be simpler to store these flags as AddrType and bool respectively? Alternatively, the struct can be marked 'packed'.
Indeed. I was optimizing prematurely.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits