[Lldb-commits] [PATCH] D81010: [lldb/DWARF] Fix PC value for artificial tail call frames for the "GNU" case
Vedant Kumar via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Jun 2 10:25:44 PDT 2020
vsk added a comment.
Thanks, this ended up being a lot cleaner than I expected!
Comment at: lldb/include/lldb/Symbol/Function.h:332
- /// The address of the call instruction. Usually an invalid address, unless
- /// this is a tail call.
- lldb::addr_t call_inst_pc;
+ bool caller_address_type : 1, is_tail_call : 1;
It seems like there's going to be around sizeof(void *) bytes worth of padding here. Maybe it'd be simpler to store these flags as AddrType and bool respectively? Alternatively, the struct can be marked 'packed'.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits