[Lldb-commits] [PATCH] D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output.

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 3 02:10:16 PDT 2020


teemperor added inline comments.


================
Comment at: lldb/include/lldb/Utility/Stream.h:417
+        write(colorcode, len);
+      }
+      return *this;
----------------
teemperor wrote:
> Nit: This can all be `PutCString(colorcode)` (which handles the nullptr check and the strlen). Same as below.
Actually nvm, I thought this is in the Stream class (not our own raw_ostream subclass).


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81058/new/

https://reviews.llvm.org/D81058





More information about the lldb-commits mailing list