[Lldb-commits] [PATCH] D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output.

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 3 01:36:14 PDT 2020


labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.

Let's talk about this more. I don't think we should cargo-cult code from llvm, especially when the cargo-culting won't actually work for the given use case. On windows, the `llvm::sys::Process::***` functions will be messing with the terminal  which does not sound like a good thing to do from a generic place like this.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81058/new/

https://reviews.llvm.org/D81058





More information about the lldb-commits mailing list