[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

Wed May 20 08:43:11 PDT 2020

shafik added inline comments.

================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:5215
+    uint32_t num_pointee_children = 0;
+    if (pointee_clang_type.IsAggregateType())
+      num_pointee_children =
----------------
jarin wrote:
> shafik wrote:
> > I am curious what cases are pointers aggregates? Do we test this case?
> As far as I understand, pointers are never aggregates, see [ https://github.com/llvm/llvm-project/blob/58684fbb6f2e6871f3f96ac8c7166a7d7486e971/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp#L2683 | IsAggregate ]].
Apologies, I misread that as `pointer_clang_type` , makes more sense now.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80254/new/

https://reviews.llvm.org/D80254