[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

Jaroslav Sevcik via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 20 07:35:30 PDT 2020

jarin added a comment.

In D80254#2046275 <https://reviews.llvm.org/D80254#2046275>, @labath wrote:

> Looks fine to me too. The way this test is phrased, it would probably make more sense under `test/API/python_api/value`, than here. (I mean, it's not technically wrong because everything is a "functionality", but i'd like to avoid putting stuff here precisely because the category is so vague.)

I was actually considering `lang/cpp` since this is about Clang's type system and how it handles pointers and references. In any case, `test/API/python_api/value` is C, so I could not even test the reference case there. Would you prefer creating a new subdirectory in `python_api`?



More information about the lldb-commits mailing list