[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

[Michael Forster via Phabricator via lldb-commits]

MForster added a subscriber: echristo.
MForster added inline comments.


================
Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:797
+
+  if (date_value > std::numeric_limits<time_t>::max() ||
+      date_value < std::numeric_limits<time_t>::min())
----------------
This is the line where the "Illegal instruction" happens. Actually [[ https://github.com/llvm/llvm-project/blob/82dbf4aca84ec889d0dc390674ff44e30441bcfd/lldb/source/Plugins/Language/ObjC/Cocoa.cpp#L797 | here ]], exactly (as there has been a follow-up change by @echristo) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80150/new/

https://reviews.llvm.org/D80150