[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

[Michael Forster via Phabricator via lldb-commits]

MForster added subscribers: gribozavr2, MForster.
MForster added a comment.

In D80150#2045632 <https://reviews.llvm.org/D80150#2045632>, @omjavaid wrote:

> This patch breaks lldb unit tests on lldb-arm-ubuntu buildbot.
>
> http://lab.llvm.org:8014/builders/lldb-arm-ubuntu/builds/1697


It also breaks our internal build bots with an "Illegal instruction". Here is the stacktrace:

  0  <redacted>libsupport.so                    0x00007f8c5f6d87ba llvm::sys::PrintStackTrace(llvm::raw_ostream&) + 58
  1  <redacted>libsupport.so                    0x00007f8c5f6d8c79
  2  <redacted>libsupport.so                    0x00007f8c5f6d71bb llvm::sys::RunSignalHandlers() + 123
  3  <redacted>libsupport.so                    0x00007f8c5f6d92fb
  4  libpthread.so.0                            0x00007f8c5e7509a0
  5  <redacted>libcore.so                       0x00007f8c764820b1 lldb_private::formatters::NSDate::FormatDateValue(double, lldb_private::Stream&) + 129
  6  <redacted>unittests_Sliblanguage_Utests.so 0x00007f8c771c29b5
  7  <redacted>unittests_Sliblanguage_Utests.so 0x00007f8c771c24d8 DataFormatterMockTest_NSDate_Test::TestBody() + 248
  8  <redacted>libgtest.so                      0x00007f8c5f85ce44 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 132
  9  <redacted>libgtest.so                      0x00007f8c5f84b532 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 114
  10 <redacted>libgtest.so                      0x00007f8c5f840866 testing::Test::Run() + 182
  11 <redacted>libgtest.so                      0x00007f8c5f840eb5 testing::TestInfo::Run() + 213
  12 <redacted>libgtest.so                      0x00007f8c5f8413e4 testing::TestCase::Run() + 228
  13 <redacted>libgtest.so                      0x00007f8c5f8461db testing::internal::UnitTestImpl::RunAllTests() + 731
  14 <redacted>libgtest.so                      0x00007f8c5f861a24 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 132
  15 <redacted>libgtest.so                      0x00007f8c5f84cf42 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 114
  16 <redacted>libgtest.so                      0x00007f8c5f845eda testing::UnitTest::Run() + 186
  17 <redacted>libgtest_Umain.so                0x00007f8c5f8b7ce1 RUN_ALL_TESTS() + 17
  18 <redacted>libgtest_Umain.so                0x00007f8c5f8b7c6a main + 186
  19 libc.so.6                                  0x00007f8c5e5bebbd __libc_start_main + 253
  20 language_tests                             0x0000556b0f40dd09
  Illegal instruction

@gribozavr2 is preparing a revert of this commit and the two follow-up changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80150/new/

https://reviews.llvm.org/D80150