[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/source/Core/ValueObject.cpp:2839-2861
+    // In case of C opaque pointers, use the pointee type and try to
+    // recreate a new ValueObjectChild using it.
+    if (!m_deref_valobj) {
+      if (Language::LanguageIsCFamily(GetPreferredDisplayLanguage())) {
+        if (HasSyntheticValue()) {
+
+          child_compiler_type = compiler_type.GetPointeeType();
----------------
Can this be merged with the code above? It seems like the only difference is the way it which we get the CompilerType.


================
Comment at: lldb/source/Core/ValueObject.cpp:2842
+    if (!m_deref_valobj) {
+      if (Language::LanguageIsCFamily(GetPreferredDisplayLanguage())) {
+        if (HasSyntheticValue()) {
----------------
What's the reason for limiting this to the C family? It seems like one could want to have a pretty printer for incomplete types in any language...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79554/new/

https://reviews.llvm.org/D79554