[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

[Raphael Isemann via Phabricator via lldb-commits]

teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

IMHO this looks good now. Maybe add a comment to the commit that this adds support for incomplete types in ValueObjects.

I think @jingham should also take a look at this to make sure this makes sense.



================
Comment at: lldb/source/Core/ValueObjectSyntheticFilter.cpp:56
   SetName(parent.GetName());
-  CopyValueData(m_parent);
+  if (m_parent->GetCompilerType().IsCompleteType())
+    CopyValueData(m_parent);
----------------
Maybe comment this line that copying the data of an incomplete type doesn't make sense as it has no (byte) size. (Previously this worked as our made-up type was empty and had a size of 0 bytes.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79554/new/

https://reviews.llvm.org/D79554