[Lldb-commits] [PATCH] D79825: [lldb/Reproducers] Add test-specific API to set the test CWD

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

In D79825#2033405 <https://reviews.llvm.org/D79825#2033405>, @labath wrote:

> It's definitely a hack, but it seems to be fairly well contained.
>
> As an aside, I've always wondered, how much we really need to switch the cwd. Now that we build tests out-of-tree, I would expect most of the file references to be cwd-independent (`getBuildArtifact`). The only remaining references are probably the ones where we work with source files, which shouldn't be too hard to fix, and also those where we still accidentally create files in the source tree (which this would help eliminate).


Sounds good. About half the API tests are failing without changing the working directory, though I suspect it's mostly the same issue. I've added it to my list of nice-to-haves.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79825/new/

https://reviews.llvm.org/D79825