[Lldb-commits] [lldb] 0796b17 - Fix error in TestNumThreads.py when frame.GetFunctionName returns none
Muhammad Omair Javaid via lldb-commits
lldb-commits at lists.llvm.org
Tue May 12 17:14:16 PDT 2020
Author: Muhammad Omair Javaid
Date: 2020-05-13T05:13:46+05:00
New Revision: 0796b170fb3bf38e6cc4e59746120b37c9a9cd9f
URL: https://github.com/llvm/llvm-project/commit/0796b170fb3bf38e6cc4e59746120b37c9a9cd9f
DIFF: https://github.com/llvm/llvm-project/commit/0796b170fb3bf38e6cc4e59746120b37c9a9cd9f.diff
LOG: Fix error in TestNumThreads.py when frame.GetFunctionName returns none
Summary:
This patch fixes an error happening in TestNumThreads.py when it encounters frame.GetFunctionName none for address only locations in stripped libc.
This error was showing up on arm-linux docker container running lldb buildbot.
Reviewers: labath
Reviewed By: labath
Subscribers: kristof.beyls, lldb-commits
Differential Revision: https://reviews.llvm.org/D79777
Added:
Modified:
lldb/test/API/functionalities/thread/num_threads/TestNumThreads.py
Removed:
################################################################################
diff --git a/lldb/test/API/functionalities/thread/num_threads/TestNumThreads.py b/lldb/test/API/functionalities/thread/num_threads/TestNumThreads.py
index cfd2941ad193..7a4a6d05d3f2 100644
--- a/lldb/test/API/functionalities/thread/num_threads/TestNumThreads.py
+++ b/lldb/test/API/functionalities/thread/num_threads/TestNumThreads.py
@@ -95,6 +95,8 @@ def test_unique_stacks(self):
# the same breakpoint.
def is_thread3(thread):
for frame in thread:
+ if frame.GetFunctionName() is None:
+ continue
if "thread3" in frame.GetFunctionName(): return True
return False
More information about the lldb-commits
mailing list