[Lldb-commits] [PATCH] D79614: Fix error reporting for qLaunchSuccess, check for fix/enable it via qSupported

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added a comment.

In D79614#2027861 <https://reviews.llvm.org/D79614#2027861>, @clayborg wrote:

> Why not just fix qLaunchSuccess by passing the string through a "escape_string(...)" function? Any packet that can return a string with unknown content should be escaped correctly. Adding a new packet doesn't really fix the problem in older debugserver/lldb-server binaries anyway.


lldb wouldn't know whether to decode the returned error string or not -- short of using a debugserver version #.  We'll need to interoperate with debugservers that send the unescaped qLaunchSuccess error messages for years to come.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79614/new/

https://reviews.llvm.org/D79614