[Lldb-commits] [PATCH] D79614: Fix error reporting for qLaunchSuccess, check for fix/enable it via qSupported

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

Why not just fix qLaunchSuccess by passing the string through a "escape_string(...)" function? Any packet that can return a string with unknown content should be escaped correctly. Adding a new packet doesn't really fix the problem in older debugserver/lldb-server binaries anyway.



================
Comment at: lldb/tools/debugserver/source/RNBRemote.cpp:1664
+  } else {
+    ret_str << "E" << m_ctx.LaunchStatusAsString(status_str);
+  }
----------------
Why now just fix this line? Something like:

```
ret_str << "E" << escape_string(m_ctx.LaunchStatusAsString(status_str));
```



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79614/new/

https://reviews.llvm.org/D79614