[Lldb-commits] [PATCH] D79586: Do not list adb devices when a device id is given

Emre Kultursay via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu May 7 10:14:19 PDT 2020


emrekultursay created this revision.
Herald added subscribers: lldb-commits, mgorny.
Herald added a project: LLDB.

On Android, this method gets called twice: first when establishing
a host-server connection, then when attaching to a process id.

Each call takes several seconds to finish (especially slower on Windows)
and eliminating the call for the typical case improves latency significantly.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79586

Files:
  lldb/source/Plugins/Platform/Android/AdbClient.cpp
  lldb/unittests/Platform/Android/AdbClientTest.cpp
  lldb/unittests/Platform/Android/CMakeLists.txt
  lldb/unittests/Platform/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79586.262684.patch
Type: text/x-patch
Size: 3776 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200507/2df2c06f/attachment.bin>


More information about the lldb-commits mailing list