[Lldb-commits] [lldb] 34a57dc - [lldb/Reproducers] Make DoConnectRemote connect to the replay server.

[Jonas Devlieghere via lldb-commits]

Author: Jonas Devlieghere
Date: 2020-05-07T10:09:09-07:00
New Revision: 34a57dc972c2d16f176e47339a7c2c95cdc31e75

URL: https://github.com/llvm/llvm-project/commit/34a57dc972c2d16f176e47339a7c2c95cdc31e75
DIFF: https://github.com/llvm/llvm-project/commit/34a57dc972c2d16f176e47339a7c2c95cdc31e75.diff

LOG: [lldb/Reproducers] Make DoConnectRemote connect to the replay server.

All entry points into ProcessGDBRemote that connect to the debug server
should connect to the replay server instead during reproducer replay.
This patch adds the necessary logic for ConnectRemote, which is
accessible from the SB API. This fixes active replay for
TestRecognizeBreakpoint.py as described in D78588.

Added: 
    

Modified: 
    lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
index d2e7f4d479cb..dbad49d62097 100644
--- a/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
@@ -649,7 +649,10 @@ Status ProcessGDBRemote::DoConnectRemote(Stream *strm,
   if (error.Fail())
     return error;
 
-  error = ConnectToDebugserver(remote_url);
+  if (repro::Loader *loader = repro::Reproducer::Instance().GetLoader())
+    error = ConnectToReplayServer(loader);
+  else
+    error = ConnectToDebugserver(remote_url);
 
   if (error.Fail())
     return error;