[Lldb-commits] [PATCH] D77843: [lldb/DataFormatters] Delete GetStringPrinterEscapingHelper

[Vedant Kumar via Phabricator via lldb-commits]

vsk marked an inline comment as done.
vsk added inline comments.


================
Comment at: lldb/source/DataFormatters/StringPrinter.cpp:42-43
+      llvm_unreachable("unsupported length");
+    memcpy(reinterpret_cast<void *>(m_data),
+           reinterpret_cast<const void *>(bytes), size);
+  }
----------------
labath wrote:
> What's up with all the `reinterpret_cast`ing? `T*` is implicitly convertible to a `void*`...
Ah thanks for catching this, I'll get rid of the redundant casts before committing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77843/new/

https://reviews.llvm.org/D77843