[Lldb-commits] [PATCH] D77843: [lldb/DataFormatters] Delete GetStringPrinterEscapingHelper
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon May 4 02:37:59 PDT 2020
labath accepted this revision.
labath added a comment.
Yeah, I think this looks good too.
================
Comment at: lldb/source/DataFormatters/StringPrinter.cpp:42-43
+ llvm_unreachable("unsupported length");
+ memcpy(reinterpret_cast<void *>(m_data),
+ reinterpret_cast<const void *>(bytes), size);
+ }
----------------
What's up with all the `reinterpret_cast`ing? `T*` is implicitly convertible to a `void*`...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77843/new/
https://reviews.llvm.org/D77843
More information about the lldb-commits
mailing list