[Lldb-commits] [PATCH] D77759: [lldb/Reproducers] Fix passive replay for functions returning string as (char*, size_t).

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 17 02:40:34 PDT 2020


labath added a comment.

Hmm... well, I like how this (active&passive) is unified at the template level. It still feels like there's too much code to implement this thing (coming from the duplication for const, non-const and static variants), but I'm not sure what can be done about that. I'll need to ponder this a bit more



================
Comment at: lldb/include/lldb/Utility/ReproducerInstrumentation.h:995
+
+template <typename Signature> struct invoke_char_ptr;
+template <typename Result, typename Class, typename... Args>
----------------
this forward decl is superfluous.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77759/new/

https://reviews.llvm.org/D77759





More information about the lldb-commits mailing list