[Lldb-commits] [PATCH] D77759: [lldb/Reproducers] Fix passive replay for functions returning string as (char*, size_t).
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Apr 16 14:31:40 PDT 2020
JDevlieghere updated this revision to Diff 258172.
JDevlieghere added a comment.
Remove duplication similar to D77602 <https://reviews.llvm.org/D77602>.
Honestly, at this point I'm not convinced that the difference between active and passive replay warrants special handling. Other than the slightly different macros, which are unfortunate but OTOH also a good indicator that something special is happening, there's not that much more to support active/passive replay than there is for the generic case.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77759/new/
https://reviews.llvm.org/D77759
Files:
lldb/include/lldb/Utility/ReproducerInstrumentation.h
lldb/source/API/SBDebugger.cpp
lldb/source/API/SBFileSpec.cpp
lldb/source/API/SBProcess.cpp
lldb/source/API/SBStructuredData.cpp
lldb/source/API/SBThread.cpp
lldb/unittests/Utility/ReproducerInstrumentationTest.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77759.258172.patch
Type: text/x-patch
Size: 19136 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200416/f8a00126/attachment-0001.bin>
More information about the lldb-commits
mailing list