[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 6 11:57:52 PDT 2020


clayborg added a comment.

In D77444#1963354 <https://reviews.llvm.org/D77444#1963354>, @labath wrote:

> In D77444#1962952 <https://reviews.llvm.org/D77444#1962952>, @clayborg wrote:
>
> > The biggest issue is maintaining the API. We can't add anything to SBCommandPluginInterface
>
>
> If we're going to be adding a new inheritable class for this feature, I'd recommend adding about half a dozen or so dummy virtual methods to it so we reserve vtable space for future expansion.


I second that!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77444/new/

https://reviews.llvm.org/D77444





More information about the lldb-commits mailing list