[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

Mon Apr 6 03:13:21 PDT 2020

labath added a comment.

In D77444#1962952 <https://reviews.llvm.org/D77444#1962952>, @clayborg wrote:

> The biggest issue is maintaining the API. We can't add anything to SBCommandPluginInterface

If we're going to be adding a new inheritable class for this feature, I'd recommend adding about half a dozen or so dummy virtual methods to it so we reserve vtable space for future expansion.

================
Comment at: lldb/test/API/api/auto-repeat-command/TestSBCommandAutoRepeat.py:1
+"""Test the lldb public C++ api for returning SBCommandReturnObject."""
+
----------------
Could you try making this a unit test (like the regular c++ unit tests)?

I know we have already have tests following this pattern, but that was because they were all written before we had googletest, and they all have a lot of problems I'm not keen on repeating.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77444/new/

https://reviews.llvm.org/D77444