[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 25 10:48:14 PDT 2020


aprantl marked an inline comment as done.
aprantl added inline comments.


================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1254
+  auto parent_desc = ast_source->getSourceDescriptor(parent.GetValue());
+  std::tie(module, created) = m_module_map_up->findOrCreateModule(
+      name, parent_desc ? parent_desc->getModuleOrNull() : nullptr,
----------------
@teemperor This is the place where we need `Module *` instead of a `const Module *`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75488/new/

https://reviews.llvm.org/D75488





More information about the lldb-commits mailing list