[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

Mon Mar 23 07:03:37 PDT 2020

teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h:318
+  /// Synthesize a clang::Module and return its ID or a default-constructed ID.
+  OptionalClangModuleID GetOrCreateClangModule(llvm::StringRef name, OptionalClangModuleID parent,
+                                  bool is_framework = false,
----------------
This probably deserves a hint that this can only be called on an TypeSystemClang that has created its own clang::ASTContext (otherwise the ASTSource could be anything and this asserts) as all other functions in TypeSystemClang otherwise work in both modes. `Should not be called when TypeSystemClang adopted an existing clang::ASTContext` or something like that.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75488/new/

https://reviews.llvm.org/D75488