[Lldb-commits] [lldb] b4a6e63 - [lldb/Target] Rework the way the inferior environment is created

[Frédéric Riss via lldb-commits]

Here’s the bot log: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/15055/steps/test/logs/stdio

> On Mar 24, 2020, at 5:10 PM, Adrian McCarthy <amccarth at google.com> wrote:
> 
> Oh, and in case I wasn't clear:  I re-enabled the test TestSettings.py locally.
> 
> On Tue, Mar 24, 2020 at 5:04 PM Adrian McCarthy <amccarth at google.com <mailto:amccarth at google.com>> wrote:
> I took a stab at this, but I'm not seeing any new test failures.  Can you point me to the specific test and provide a log showing the failures?
> 
> I've been using `ninja check-lldb`, which runs (almost everything) and none of the failures I'm seeing are related to inherit-env.  I assume the problem you're seeing is in TestSettings.py, but I've never figured out how to run individual Python-based lldb tests since all the dotest.py stuff was re-written.  I've started up lldb interactively and tried to emulate the commands that test executes via SBAPI, but everything worked as expected.
> 
> Adrian.
> 
> On Tue, Mar 24, 2020 at 8:19 AM Adrian McCarthy <amccarth at google.com <mailto:amccarth at google.com>> wrote:
> I'll take a look this morning.
> 
> On Tue, Mar 24, 2020 at 7:00 AM Pavel Labath <pavel at labath.sk <mailto:pavel at labath.sk>> wrote:
> On 23/03/2020 17:17, Frédéric Riss via lldb-commits wrote:
> > The new testing for “inherit-env=false” is failing on Windows. I skipped the test for now.
> > 
> > Could it be that it never worked there? (In which case XFail would be a better resolution)
> > Does anyone have easy access to a Windows build to try it out?
> > 
> > Thanks,
> > Fred
> 
> My guess is that this "defensive check"
> <https://github.com/llvm/llvm-project/blob/master/lldb/source/Host/windows/ProcessLauncherWindows.cpp#L26 <https://github.com/llvm/llvm-project/blob/master/lldb/source/Host/windows/ProcessLauncherWindows.cpp#L26>>
> prevents us from passing a completely blank environment. I am tempted to
> just delete it and see what happens, but maybe Adrian is able to do a
> quick test of this?
> 
> pl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200324/e90a0465/attachment.html>