<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Here’s the bot log: <a href="http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/15055/steps/test/logs/stdio" class="">http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/15055/steps/test/logs/stdio</a><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Mar 24, 2020, at 5:10 PM, Adrian McCarthy <<a href="mailto:amccarth@google.com" class="">amccarth@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Oh, and in case I wasn't clear: I re-enabled the test TestSettings.py locally.</div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Mar 24, 2020 at 5:04 PM Adrian McCarthy <<a href="mailto:amccarth@google.com" class="">amccarth@google.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr" class="">I took a stab at this, but I'm not seeing any new test failures. Can you point me to the specific test and provide a log showing the failures?<div class=""><br class=""></div><div class="">I've been using `ninja check-lldb`, which runs (almost everything) and none of the failures I'm seeing are related to inherit-env. I assume the problem you're seeing is in TestSettings.py, but I've never figured out how to run individual Python-based lldb tests since all the dotest.py stuff was re-written. I've started up lldb interactively and tried to emulate the commands that test executes via SBAPI, but everything worked as expected.</div><div class=""><br class=""></div><div class="">Adrian.</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Mar 24, 2020 at 8:19 AM Adrian McCarthy <<a href="mailto:amccarth@google.com" target="_blank" class="">amccarth@google.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr" class="">I'll take a look this morning.</div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Mar 24, 2020 at 7:00 AM Pavel Labath <<a href="mailto:pavel@labath.sk" target="_blank" class="">pavel@labath.sk</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 23/03/2020 17:17, Frédéric Riss via lldb-commits wrote:<br class="">
> The new testing for “inherit-env=false” is failing on Windows. I skipped the test for now.<br class="">
> <br class="">
> Could it be that it never worked there? (In which case XFail would be a better resolution)<br class="">
> Does anyone have easy access to a Windows build to try it out?<br class="">
> <br class="">
> Thanks,<br class="">
> Fred<br class="">
<br class="">
My guess is that this "defensive check"<br class="">
<<a href="https://github.com/llvm/llvm-project/blob/master/lldb/source/Host/windows/ProcessLauncherWindows.cpp#L26" rel="noreferrer" target="_blank" class="">https://github.com/llvm/llvm-project/blob/master/lldb/source/Host/windows/ProcessLauncherWindows.cpp#L26</a>><br class="">
prevents us from passing a completely blank environment. I am tempted to<br class="">
just delete it and see what happens, but maybe Adrian is able to do a<br class="">
quick test of this?<br class="">
<br class="">
pl<br class="">
</blockquote></div>
</blockquote></div>
</blockquote></div>
</div></blockquote></div><br class=""></body></html>