[Lldb-commits] [PATCH] D74157: [lldb/API] NFC: Reformat SBThread::GetStopDescription()
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Feb 7 11:12:38 PST 2020
jingham added inline comments.
================
Comment at: lldb/source/Target/Thread.cpp:601
raw_stop_description = stop_info_sp->GetDescription();
+ assert(!raw_stop_description.empty() &&
+ "StopInfo returned an empty description.");
----------------
It is possible to have a StopInfo with reason eStopReasonNone. I don't think we currently use that, but there's nothing outlawing it. We should treat that the same as no stop reason, so we shouldn't require a description in that case. Other than that this is fine.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74157/new/
https://reviews.llvm.org/D74157
More information about the lldb-commits
mailing list