[Lldb-commits] [PATCH] D74160: [lldb] removed no longer needed CMakeDependentOption

Konrad Wilhelm Kleine via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 6 13:29:19 PST 2020


kwk created this revision.
kwk added a reviewer: JDevlieghere.
Herald added subscribers: lldb-commits, mgorny.
Herald added a project: LLDB.
kwk updated this revision to Diff 242991.
kwk added a comment.
kwk edited the summary of this revision.
kwk edited the summary of this revision.

Removed typo in commit message


In D66791 <https://reviews.llvm.org/D66791> I've introduced this `CMakeDependentOption` <https://cmake.org/cmake/help/latest/module/CMakeDependentOption.html> but in
D71306 <https://reviews.llvm.org/D71306> @JDevlieghere has changed the way optional dependencies
are handled in LLDB. Today there's no occurence of
`cmake_dependent_option` inside the lldb source tree.

That's why this include can be removed.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74160

Files:
  lldb/cmake/modules/LLDBConfig.cmake


Index: lldb/cmake/modules/LLDBConfig.cmake
===================================================================
--- lldb/cmake/modules/LLDBConfig.cmake
+++ lldb/cmake/modules/LLDBConfig.cmake
@@ -1,6 +1,5 @@
 include(CheckCXXSymbolExists)
 include(CheckTypeSize)
-include(CMakeDependentOption)
 
 set(LLDB_PROJECT_ROOT ${CMAKE_CURRENT_SOURCE_DIR})
 set(LLDB_SOURCE_ROOT "${CMAKE_CURRENT_SOURCE_DIR}/source")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74160.242991.patch
Type: text/x-patch
Size: 407 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200206/a666a495/attachment.bin>


More information about the lldb-commits mailing list