[Lldb-commits] [PATCH] D73279: testsuite: generalize `DWARFASTParserClangTests` based on `DWARFExpressionTest`'s YAML

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added a comment.

I like the direction!



================
Comment at: lldb/unittests/TestingSupport/Symbol/YAMLModuleTester.cpp:1
+//===- YAMLModuleTester.cpp -------------------------------------*- C++ -*-===//
+//
----------------
Nit: the `-*- C++ -*-` only makes sense in a .h file where the language is ambiguous.


================
Comment at: lldb/unittests/TestingSupport/Symbol/YAMLModuleTester.h:24
+class YAMLModuleTester {
+  //  SubsystemRAII<FileSystem> subsystems;
+  SubsystemRAII<FileSystem, HostInfo, TypeSystemClang> subsystems;
----------------
?


================
Comment at: lldb/unittests/TestingSupport/Symbol/YAMLModuleTester.h:37
+
+  // Evaluate a raw DWARF expression.
+  llvm::Expected<Scalar> Eval(llvm::ArrayRef<uint8_t> expr);
----------------
///


================
Comment at: lldb/unittests/TestingSupport/Symbol/YAMLModuleTester.h:38
+  // Evaluate a raw DWARF expression.
+  llvm::Expected<Scalar> Eval(llvm::ArrayRef<uint8_t> expr);
+};
----------------
Should this be implemented in a sub-class that is specific to the DWARFExpression tests?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73279/new/

https://reviews.llvm.org/D73279